Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit plan if the name is too long #257

Closed
federicofortini opened this issue Apr 30, 2024 · 10 comments
Closed

Unable to edit plan if the name is too long #257

federicofortini opened this issue Apr 30, 2024 · 10 comments
Labels
bug Something isn't working

Comments

@federicofortini
Copy link

Describe the bug
I have a bad habit of being verbose in descriptions and this led me to notice that I can't edit my "plan" because the gear icon is beyond the column size. I'll leave it up to you to choose the best way to handle this use case

To Reproduce
Steps to reproduce the behavior:

  1. Create a plan with a name long at least 37 character (mine is docker-compose-and-container-configs)
  2. Try to edit it using the gear icon

Expected behavior
I expect to be able to modify a plan

Screenshots
image

Platform Info

  • OS and Architecture - Docker container on Linux x64
  • Backrest Version - 0.17.2
@federicofortini federicofortini added the bug Something isn't working label Apr 30, 2024
@federicofortini
Copy link
Author

federicofortini commented Apr 30, 2024

Tried to manually increase the size of the side column from "Chrome DevTools" to 400, and now I can see the edit icon.
image

@modem
Copy link

modem commented May 2, 2024

In #126 I suggested to move that button to the plan page, next to the other buttons. It may be a good solution for these cases.

@garethgeorge
Copy link
Owner

Hey, going ahead and addressing this in 5ef890c , I've gone ahead and fixed the right-alignment of the settings icon.

I'm conflicted re: moving the icon to the page for the repo / plan, I think it adds clicks for some flows e.g. switching between the plan config and the repo config to view the hook configuration, etc.

I think correctly right-aligning it e.g.
image

should cut down on miss-clicks.

@federicofortini
Copy link
Author

Hi, thank you for your feedback! How can I try it? I'm using the docker image. I checked and can't find a new 'nightly' updated today. If you didn't plan to have a new docker image for this little modification, I can manually replace the two files edited by your commit.

@garethgeorge
Copy link
Owner

Hey, you can try this out by downloading a binary from https://github.com/garethgeorge/backrest/actions/runs/8960742109 and copy it into a docker image, afraid I don't have nightly releases setup yet.

A quick caveat is that this is an early version of the 1.0.0 release which includes a few config migrations.

@lakemike
Copy link

lakemike commented May 13, 2024

As a workaround, you can select the plan or repository name, then hit the "tab" key in your browser and it should jump to the wheel icon even if it's hidden.

@federicofortini
Copy link
Author

federicofortini commented May 13, 2024 via email

@garethgeorge
Copy link
Owner

Should be resolved in 1.0.0 , feel free to give this a ping if you're still running into issues!

@federicofortini
Copy link
Author

federicofortini commented May 20, 2024 via email

@federicofortini
Copy link
Author

Updated fiew minute ago. Now I can edit my plan 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants