Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests leak resources #436

Open
voelzmo opened this issue Oct 25, 2021 · 2 comments
Open

Integration tests leak resources #436

voelzmo opened this issue Oct 25, 2021 · 2 comments
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/aws Amazon web services platform/infrastructure priority/3 Priority (lower number equals higher priority)

Comments

@voelzmo
Copy link
Member

voelzmo commented Oct 25, 2021

How to categorize this issue?

/area dev-productivity
/kind bug
/priority 3
/platform aws

What happened:
I recently PRed a change which had failing integration tests: #424. As a result, we got leaking resources in our TM cluster, namely cluster, infrastructure and things associated with these objects. Not only is this a waste of resources, it also required cleaning up the leaked resources before the fix would pass another IT run, as the old resources were still picked up by the reconciliation loop in the new test runs, causing it to fail.

What you expected to happen:
Even failing tests should not leak resources. Leaked resources from previous test runs should not cause new test runs to fail.

Anything else we need to know?:
This seems to be also true for other extension-providers, such as Azure.

@voelzmo voelzmo added the kind/bug Bug label Oct 25, 2021
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) platform/aws Amazon web services platform/infrastructure priority/3 Priority (lower number equals higher priority) labels Oct 25, 2021
@timebertt
Copy link
Member

@voelzmo
Copy link
Member Author

voelzmo commented Oct 26, 2021

Thanks for cross-linking! When I talked to @ialidzhikov about this, he mentioned this has been mentioned before somewhere! ;)

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Apr 25, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/aws Amazon web services platform/infrastructure priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

3 participants