Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid replacing secret with new account for existing Shoots #40

Open
ialidzhikov opened this issue Feb 20, 2020 · 2 comments
Open

Forbid replacing secret with new account for existing Shoots #40

ialidzhikov opened this issue Feb 20, 2020 · 2 comments
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@ialidzhikov
Copy link
Member

What would you like to be added:
Currently we don't have a validation that would prevent user to replace its cloudprovider secret with credentials for another account. Basically we do have only a warning in the dashboard - ref gardener/dashboard#422.

Steps to reproduce:

  1. Get an existing Shoot.
  2. Update its secret with credentials for another account.
  3. Ensure that on new reconciliation, new infra resources will be created in the new account. The old infra resources and machines in the old account will leak.
    For me the reconciliation failed at
    lastOperation:
      description: Waiting until the Kubernetes API server can connect to the Shoot
        workers
      lastUpdateTime: "2020-02-20T14:56:43Z"
      progress: 89
      state: Processing
      type: Reconcile

wtih reason

$ k describe svc -n kube-system vpn-shoot
Events:
  Type     Reason                   Age                  From                Message
  ----     ------                   ----                 ----                -------
  Normal   EnsuringLoadBalancer     7m38s (x6 over 10m)  service-controller  Ensuring load balancer
  Warning  SyncLoadBalancerFailed   7m37s (x6 over 10m)  service-controller  Error syncing load balancer: failed to ensure load balancer: could not find any suitable subnets for creating the ELB

Why is this needed:
Prevent users to harm themselves.

@ialidzhikov ialidzhikov changed the title Forbid changing replacing secret with new account for existing Shoots Forbid replacing secret with new account for existing Shoots Feb 20, 2020
@rfranzke
Copy link
Member

g/g core cannot do it. Isn’t it rather an issue for the various extension providers?

@ialidzhikov ialidzhikov transferred this issue from gardener/gardener Feb 20, 2020
@ialidzhikov
Copy link
Member Author

Yes, right. I opened now issues to the provider specific repos.

@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Apr 21, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

3 participants