Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Error Handling in Delta Snapshot Deletion Process #652

Open
seshachalam-yv opened this issue Jul 27, 2023 · 1 comment
Open
Assignees
Labels
exp/beginner Issue that requires only basic skills kind/enhancement Enhancement, improvement, extension

Comments

@seshachalam-yv
Copy link
Contributor

seshachalam-yv commented Jul 27, 2023

Enhancement (What you would like to be added):

Improve the error handling mechanism in the delta snapshot deletion process here. The proposed changes include:

  1. Continuing with the deletion of the rest of the "deletable" delta snapshots even when an error is encountered, instead of halting the process.
  2. Concatenating all errors encountered during the deletion process using errors.Join(), and returning this concatenated error at the end of the process.

Note: This enhancement is based on the review comment in this #640 (comment).

Motivation (Why is this needed?):
The current implementation stops the garbage collection process of delta snapshots if there's an error with the deletion of a particular snapshot. This could be due to an intermittent error or an issue specific to a single snapshot. The proposed enhancement will ensure that a one-off error doesn't halt the entire process, while still effectively communicating to the function caller that there were errors in deleting delta snapshots.

Approach/Hint to the implement solution (optional):

  1. Modify the deletion process to continue deleting the remaining snapshots even when an error is encountered.
  2. Use the errors.Join() function to concatenate all errors encountered during the process.
@seshachalam-yv seshachalam-yv added the kind/enhancement Enhancement, improvement, extension label Jul 27, 2023
@seshachalam-yv seshachalam-yv added the exp/beginner Issue that requires only basic skills label Jul 27, 2023
@anveshreddy18
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/beginner Issue that requires only basic skills kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

No branches or pull requests

2 participants