Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-built binaries for Windows and Electron 2.0.2 #294

Closed
simone opened this issue Jun 15, 2018 · 8 comments
Closed

Pre-built binaries for Windows and Electron 2.0.2 #294

simone opened this issue Jun 15, 2018 · 8 comments

Comments

@simone
Copy link

simone commented Jun 15, 2018

Hi,
first of all thank for your library, it's veri useful. I would ask you to upload on S3 the prebuilt for windows of electron 2.0.2.

I'm reading you can use AppVeyor or Travis to make the task in CI.

Let me know if you need help

@hhaidar
Copy link
Contributor

hhaidar commented Aug 8, 2018

+1

@hhaidar
Copy link
Contributor

hhaidar commented Aug 17, 2018

I've added builds for electron 1.8 and 2 in #313.

@galkahana please let me know if there's anything else I should do.

@galkahana
Copy link
Owner

ok. so we got electron now.
windows is still a TODO

@hhaidar
Copy link
Contributor

hhaidar commented Aug 20, 2018

via #316, thanks again @galkahana

@galkahana
Copy link
Owner

@hhaidar thank you for your PR :)

ok, we should have windows now too.

@simone
Copy link
Author

simone commented Aug 24, 2018

Cool, works perfectly with electron-builder also from my mac osx. Many thanks.
$ npm run build:prod && npx electron-builder build --windows
• electron-builder version=20.28.2
• loaded configuration file=app/electron-builder.json
• writing effective config file=app-builds/builder-effective-config.yaml
• rebuilding native production dependencies platform=win32 arch=x64
• packaging platform=win32 arch=x64 electron=2.0.7 appOutDir=app-builds/win-unpacked
• building target=portable file=app-builds/app.exe archs=x64

deps:
"hummus": "1.0.90",

devDeps:
"electron": "2.0.7",
"electron-builder": "20.28.2",

@simone simone closed this as completed Aug 24, 2018
@hhaidar
Copy link
Contributor

hhaidar commented Sep 4, 2018

@simone are you having any issues getting electron-builder to download the correct binaries for cross-platform builds? For example, building for Linux on OSX?

@simone
Copy link
Author

simone commented Sep 5, 2018

Let me check...
No, the Linux build don' seem to work from OSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants