Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPI resolution not read/written correctly for some JPEGs #11

Open
galfar opened this issue Feb 7, 2018 · 1 comment
Open

DPI resolution not read/written correctly for some JPEGs #11

galfar opened this issue Feb 7, 2018 · 1 comment
Labels
bug Something isn't working DeskewCmdLine

Comments

@galfar
Copy link
Owner

galfar commented Feb 7, 2018

The issue is caused by missing JFIF header in the file - only EXIF is present.

Adobe's SW apparently switched to EXIF only recently:
https://feedback.photoshop.com/photoshop_family/topics/jpeg_format_different_between_cs2_and_cs6?topic-reply-list%5Bsettings%5D%5Bfilter_by%5D=all

To fix this we need to read and parse EXIF data which is in fact a TIFF directory. So if LibTiff that Deskew already uses could be reused for this then fixing this would not take that much time. Otherwise this will have to wait.

Test image:

@galfar galfar added minor bug Something isn't working labels Jan 19, 2020
@galfar
Copy link
Owner Author

galfar commented Oct 19, 2020

Clarification: problem is not that Deskew cannot write DPI value to output JPEG files. It cannot read DPI of the input and then does not know what to write to the output (and leaves the default).

A workaround (and maybe generally useful) would be an option to force DPI of the output to certain value.

galfar added a commit that referenced this issue Oct 28, 2021
Also switched Imaging's physical resolution metadata helpers to double precision floats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DeskewCmdLine
Projects
None yet
Development

No branches or pull requests

1 participant