Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to fail test if anything goes wrong. #1323

Open
bernt-matthias opened this issue Nov 17, 2022 · 0 comments
Open

Possibility to fail test if anything goes wrong. #1323

bernt-matthias opened this issue Nov 17, 2022 · 0 comments

Comments

@bernt-matthias
Copy link
Contributor

planemo test is currently successful if there are errors like:

  • Exception: The tool XYZ targets version 21.09 of Galaxy, you should upgrade Galaxy to ensure proper functioning of this tool.
  • or in case of xml parsing errors (which would be covered by the linter)
  • ...?

Currently Galaxy only prints a warning to the logs, it would be nice if we could configure the Galaxy that is spun up for the tests such that it fails (crashes?) in such cases.

Guess this would require changes to planemo and Galaxy.

Still, there is then the problem how to use this in CI, since the test job ignores the exit code of planemo test (at the moment) .. maybe record it and use in the combine_outputs job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant