nested combineReducers

[mathisonian]

I'm having some trouble getting this library to work with my existing redux reducers. I believe the problem is that I am nesting multiple combineReducers calls in my root reducer.

So for a simplified example I have the following files:

// root-reducer.js
import { combineReducers } from 'redux-immutable';
import complexReducer from './complex-reducer';
export default combineReducers({
  complexReducer
});

// complex-reducer.js
import { combineReducers } from 'redux-immutable';
import reducerA from './reducer-a';
import reducerB from './reducer-b';
import reducerC from './reducer-c';

export default combineReducers({
  reducerA,
  reducerB,
  reducerC
});

When it tries to set the initial state of the complex reducer, it is passed in an undefined value from the root reducer and gives this error:

The previous state received by the reducer is of unexpected type. Expected argument to be an instance of Immutable.Iterable with the following properties: "reducerA", "reducerB", "reducerC".

and then fails on the withMutations call here because inputState is undefined.

This pattern is supported by redux (see reduxjs/redux#738). Is this possible in redux-immutable? Sorry if I am missing something obvious - am fairly new to the redux ecosystem.

[holymonson]

Met the same issue too. When nesting combineReducers, state would be undefined if no nested initialState provided. combineReducers from 'redux' can handle but this not, seems providing an default empty Immutable.Map when state === undefined would be a choice to fix it.

[gajus]

Does anyone want to practise their PR skills?

[mathisonian]

I'm happy to send a PR. Should be able to get something together today.

[gajus]

v3.0.6 has been published

[mathisonian]

thanks @gajus!