Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package size #19

Open
QuarksToQuasars opened this issue Nov 7, 2016 · 5 comments
Open

Improve package size #19

QuarksToQuasars opened this issue Nov 7, 2016 · 5 comments

Comments

@QuarksToQuasars
Copy link

QuarksToQuasars commented Nov 7, 2016

The package is quite heavy (actually too heavy) with having full "babel": "^5.8.23" as dependency. As far as I can see only babel-polyfill is need. Is that correct?

If yes, would it make sense / possible to replace this with babel-polyfill or babel-runtime (or even just core-js only) and move babel to devDependencies?

@gajus gajus changed the title Remove babel dependency Improve package size Nov 7, 2016
@gajus
Copy link
Owner

gajus commented Nov 7, 2016

As far as I can tell, you are right. In fact, "browser" bundle ought to be removed altogether. There is no good use case, everyone is using a package manager these days (or should be).

I cannot think of a reason for needing Babel as a dependency. I'd be happy to investigate further. However, the code base is quite out of sync with my current workflow. I have recently brought one of the libraries that I maintain up to speed (see gajus/swing#86). If you could raise an equivalent PR, I'd be happy to investigate the bundle size.

QuarksToQuasars added a commit to QuarksToQuasars/contents that referenced this issue Nov 11, 2016
Only babel-polyfill is used and can be replaced directly by core-js.

Fixes gajus#19
@QuarksToQuasars
Copy link
Author

I was rather worrying about the dependency tree rather than the actual (browser) bundle size. Bundle actually increased a bit ... probably due to the newer core-js, however, as you said most people probably don't care and using it as a package dependency rather than as browser bundle.

@QuarksToQuasars
Copy link
Author

Doesn't it make sense ?

@gajus
Copy link
Owner

gajus commented Nov 25, 2016

It makes sense. I don't have a use case for contents package at the moment. Therefore, prioritising its development over active dependencies would be irrational. However, if there is a Good Samaritan that wants to contribute a PR, I am happy to review it and release it if appropriate.

@QuarksToQuasars
Copy link
Author

Sorry, I was referring to both my reasoning and the respective PR #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants