Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary String to Text coercion #222

Open
OutOfInception opened this issue Mar 4, 2016 · 2 comments
Open

Unnecessary String to Text coercion #222

OutOfInception opened this issue Mar 4, 2016 · 2 comments

Comments

@OutOfInception
Copy link
Contributor

The String datastore type now has a maximum length of 1500, see, https://cloud.google.com/appengine/docs/java/datastore/entities#Java_Properties_and_value_types. Gaelyk still maintains the old limit of 500 in https://github.com/gaelyk/gaelyk/blob/master/core/src/main/groovyx/gaelyk/datastore/DatastoreEntityCoercion.java#L84.
@musketyr
Copy link
Contributor

musketyr commented Mar 7, 2016

thanks for letting us know! This should be easily to fix

@codeconsole
Copy link
Contributor

It says 1500 bytes, not characters. I believe a character in java is 2 bytes?

Have you tested and entity with 1500 characters?

musketyr added a commit that referenced this issue Jun 5, 2018
@musketyr
Merge pull request #227 from OutOfInception/issue/222
3c60de3 
#222 Text coercion based on datastore indexed String limit fix (500 c…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeconsole @musketyr @OutOfInception