Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package structure #469

Open
arngrimur opened this issue Jan 16, 2024 · 0 comments · May be fixed by #543
Open

Fix package structure #469

arngrimur opened this issue Jan 16, 2024 · 0 comments · May be fixed by #543

Comments

@arngrimur
Copy link

Today when importingmimetype using go mod vendor some unnecessary files ar e included since they are in the same package as the go files

By moving mime.go, mimetypes.go and tree.go to folder pkg it is possible to reduce the size of vendored files by almost 1.5M. It is not a lot but if applications vendoring lots of libs they accumulate

Thanks!

P:S I can do the work and send a PR if you want

@gabriel-vasile gabriel-vasile linked a pull request Jun 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant