Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between README and code regarding sonar.gitlab.quality_gate_fail_mode #263

Open
p3k opened this issue Dec 5, 2019 · 0 comments · Fixed by javamachr/sonar-gitlab-plugin#12

Comments

@p3k
Copy link

p3k commented Dec 5, 2019

In the README it says (please note the case):

sonar.gitlab.quality_gate_fail_mode | Quality gate fail mode: error, warn or none (default error)

| sonar.gitlab.quality_gate_fail_mode | Quality gate fail mode: error, warn or none (default error) | Administration, Variable | >= 3.0.0 |

…while in the Java code the properties are handled uppercase:

At least it becomes obvious that setting sonar.gitlab.quality_gate_fail_mode=none does not change anything while sonar.gitlab.quality_gate_fail_mode=NONE does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant