Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty Testing #33

Open
i5hi opened this issue Apr 18, 2022 · 2 comments
Open

Difficulty Testing #33

i5hi opened this issue Apr 18, 2022 · 2 comments

Comments

@i5hi
Copy link

i5hi commented Apr 18, 2022

Hey, we were about to start building a cyphernode sdk and found your work.

I haven't been able to test it successfully locally.

tsc breaks with many errors.

I updated the tsconfig.json with some other flags I usually use and that has brought it down from 60ish errors to 14.

{
  "compilerOptions": {
    "target": "es5",
    "module": "commonjs",
    "lib": ["dom", "es6"],
    "allowJs": true,
    "sourceMap": true, 
    "strict": false,
    "strictNullChecks": false,
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "allowSyntheticDefaultImports": true,
    "esModuleInterop": true,
    "skipLibCheck": true,
    "forceConsistentCasingInFileNames": true
  },
  "include": ["src", "src/.ts"],
  "exclude": ["node_modules"],
}
Found 14 errors in 8 files.

Errors  Files
     3  src/clients/btcClient.spec.ts:27
     1  src/clients/btcClient.ts:186
     2  src/clients/lncClient.ts:52
     3  src/clients/otsClient.spec.ts:4
     2  src/clients/otsClient.ts:16
     1  src/examples/createLnInvoice.ts:20
     1  src/lib/cryptoUtil.ts:11
     1  src/transport/cypherNodeHttpTransportNoAgent.ts:21
     ```
     
     
I'm having a go at debugging this. 

Let me know if you have any pointers or info that could help.
@i5hi
Copy link
Author

i5hi commented Apr 18, 2022

The README.md is also missing specifying the ENV CYPHERNODE_API_KEY_ID

@gabidi
Copy link
Owner

gabidi commented Apr 29, 2022

Hi @i5hi , thanks for submitting this issue.
it's been quite a while since i've updated this repo. Not sure if all functions and types are still in sync with CN.
I'll check the TS errors when i get the time and update you/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants