Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Update check in isSSR function to use asset manifest #46

Open
ganemone opened this issue Dec 4, 2017 · 3 comments
Open

Update check in isSSR function to use asset manifest #46

ganemone opened this issue Dec 4, 2017 · 3 comments
Assignees

Comments

@ganemone
Copy link
Contributor

ganemone commented Dec 4, 2017

We are currently using a regular expression to match javascript files as a hack to allow viewing them in the browser. We should instead check against the asset manifest so we know exactly what file is being requested

@ganemone ganemone self-assigned this Dec 4, 2017
@lhorie
Copy link
Contributor

lhorie commented Jan 31, 2018

Related issue: #116 - merely checking asset manifest will not be sufficient to handle situations where the asset is dynamically generated or obtained from a service. A common example is PDF downloads.

@mlmorg
Copy link

mlmorg commented Mar 22, 2019

Won't do this. Will do path-based heuristic for SSR.

@mlmorg mlmorg closed this as completed Mar 22, 2019
@old-fusion-bot old-fusion-bot bot reopened this Mar 22, 2019
@old-fusion-bot
Copy link

This issue was automatically re-opened because it is referenced in a TODO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants