Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Document or expose additional information for escaped HTML strings #272

Open
KevinGrandon opened this issue Aug 26, 2018 · 0 comments
Open

Comments

@KevinGrandon
Copy link
Contributor

Right now when a developer performs console.log() on a string escaped by the html method in fusion-core, it's logged as an empty object. This makes it pretty confusing, so it would be nice if

At a minimum we should have some more comments in sanitization.js. It would be nice if we could expose some additional information as enumerable keys, possibly nesting the object? Quick sketch:

    const obj = {
         description: "An escaped HTML value. Use consumeSanitizedHTML to output."
    };
    Object.defineProperty(obj, key, {
      enumerable: false,
      configurable: false,
      value: head + values.map((s, i) => escape(s) + rest[i]).join(''),
    });
return obj;

const obj = {};
Object.defineProperty(obj, key, {
enumerable: false,
configurable: false,
value: head + values.map((s, i) => escape(s) + rest[i]).join(''),
});
return obj;

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant