Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify storage keys #222

Open
2 of 4 tasks
fsmanuel opened this issue Jan 6, 2017 · 3 comments
Open
2 of 4 tasks

Unify storage keys #222

fsmanuel opened this issue Jan 6, 2017 · 3 comments

Comments

@fsmanuel
Copy link
Member

fsmanuel commented Jan 6, 2017

  • Use : to delimit key parts
  • Fallback to - delimiter
  • Make it configurable (via environment.js)
  • Make it possible to prepend a namespace
@ruzz311
Copy link

ruzz311 commented Feb 8, 2017

Rather than force a delimiter (such as ':' or '-' suggested above), could you allow configuration of the delimiter? If non is configured, then fallback to one of the two options?

@fsmanuel
Copy link
Member Author

fsmanuel commented Feb 9, 2017

@ruzz311 sure! I'll keep that in mind when I implement it.

@fsmanuel
Copy link
Member Author

fsmanuel commented Feb 7, 2018

@ruzz311 after almost a year I found some time to implement a namespace option that uses a configurable delimiter. It does not yet use the delimiter for the other key parts as that would require a migration mechanism for existing keys. I think about a follow up PR to do that. If you still use the addon and have some time I would appreciate a review for #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants