Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust handling of unexpected payloads #36

Open
sliemeobn opened this issue Oct 19, 2023 · 0 comments
Open

More robust handling of unexpected payloads #36

sliemeobn opened this issue Oct 19, 2023 · 0 comments

Comments

@sliemeobn
Copy link

Currently unexpected payloads sent by the broker will result in either a crash (precondition) or undefined behavior, because it is basically ignored.

All preconditions that can actually occur should rather cause an error and take the channel down cleanly (eg: a valid frame from the broker that is unexpected).

On the other hand, valid broker response frames that arrive without a matching requests are ignored - or worse, just forwarded up the chain to a mismatching request - only to be then converted to an error (outside of the channel handling pipeline).

Ideally, the channel pipeline understands these mismatches and also cleanly takes the channel down with an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant