Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'zoom' not listed as a valid propType in the index.ts file #443

Open
nzayatz14 opened this issue May 19, 2020 · 2 comments · May be fixed by #445 or #466
Open

'zoom' not listed as a valid propType in the index.ts file #443

nzayatz14 opened this issue May 19, 2020 · 2 comments · May be fixed by #445 or #466

Comments

@nzayatz14
Copy link

You have several examples using the zoom prop to set the zoom level of the map, but this prop is not listed in the IMapProps definition in the index.ts file, making it unusable for typescript projects.

Current value:

export interface IMapProps extends google.maps.MapOptions {
  google: GoogleAPI
  loaded?: boolean

  style?: Style
  containerStyle?: Style

  bounds?: google.maps.LatLngBounds | google.maps.LatLngBoundsLiteral
  centerAroundCurrentLocation?: boolean
  initialCenter?: google.maps.LatLngLiteral
  center?: google.maps.LatLngLiteral

  visible?: boolean

  onReady?: mapEventHandler
  onClick?: mapEventHandler
  onDragend?: mapEventHandler
  onRecenter?: mapEventHandler
  onBoundsChanged?: mapEventHandler
  onCenterChanged?: mapEventHandler
  onDblclick?: mapEventHandler
  onDragstart?: mapEventHandler
  onHeadingChange?: mapEventHandler
  onIdle?: mapEventHandler
  onMaptypeidChanged?: mapEventHandler
  onMousemove?: mapEventHandler
  onMouseover?: mapEventHandler
  onMouseout?: mapEventHandler
  onProjectionChanged?: mapEventHandler
  onResize?: mapEventHandler
  onRightclick?: mapEventHandler
  onTilesloaded?: mapEventHandler
  onTiltChanged?: mapEventHandler
  onZoomChanged?: mapEventHandler
}
@mandros1
Copy link

mandros1 commented May 20, 2020 •
edited

+1 I also noticed this, which is weird since it is so boldly simple in the readme, but I did read somewhere in their readme that the bounds property should set the zoom as well (which makes sense) but I still haven't been able to get it to do anything, the original code of it is below

var points = [
  { lat: 42.02, lng: -77.01 },
  { lat: 42.03, lng: -77.02 },
  { lat: 41.03, lng: -77.04 },
  { lat: 42.05, lng: -77.02 }
]
const bounds = new this.props.google.maps.LatLngBounds()

for (var i = 0; i < points.length; i++) {
  bounds.extend(points[i]);
}

return (
  <Map 
    google={this.props.google}
    style={containerStyle}
    initialCenter={{
        lat: 42.39,
        lng: -72.52
    }}
    bounds={bounds}
  >)

@luiscassih
Copy link

Adding the @types/googlemaps package solved the zoom issue with typescript but now I've facing another ts compiler error with TS7006: Parameter 'event' implicitly has an 'any' type. on ./node_modules/google-maps-react/index.d.ts:27:70
Makes this package unusable for me on typescript

@MaciekBaron MaciekBaron linked a pull request May 27, 2020 that will close this issue
Open
@hirokikondo86 hirokikondo86 linked a pull request Aug 12, 2020 that will close this issue
Open
@pedox pedox mentioned this issue Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add zoom property to IMapProps MaciekBaron/google-maps-react
Add zoom and Controls to IMapProps
3 participants
@luiscassih @nzayatz14 @mandros1