Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Use AnyDataFrame and AnyExecutionEngine annotations #402

Open
goodwanghan opened this issue Dec 23, 2022 · 1 comment · Fixed by #396
Open

[FEATURE] Use AnyDataFrame and AnyExecutionEngine annotations #402

goodwanghan opened this issue Dec 23, 2022 · 1 comment · Fixed by #396
Labels
documentation Improvements or additions to documentation enhancement New feature or request low priority refactoring

Comments

@goodwanghan
Copy link
Collaborator

We created these two TypeVars for readability. We need to refactor the entire code space to use them.
@goodwanghan goodwanghan added documentation Improvements or additions to documentation enhancement New feature or request refactoring low priority labels Dec 23, 2022
@goodwanghan goodwanghan linked a pull request Dec 28, 2022 that will close this issue
Add fugue API #396
Merged
@goodwanghan
Copy link
Collaborator Author

fugue/fugue/dataframe/dataframe.py

Line 25 in 49d3724

AnyDataFrame = TypeVar("AnyDataFrame", "DataFrame", object)

fugue/fugue/execution/execution_engine.py

Line 40 in 49d3724

AnyExecutionEngine = TypeVar("AnyExecutionEngine", object, None)

@goodwanghan goodwanghan reopened this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request low priority refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fugue API fugue-project/fugue
1 participant
@goodwanghan