Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up preprocessor directives #577

Open
wallymathieu opened this issue Dec 17, 2023 · 0 comments
Open

Clean up preprocessor directives #577

wallymathieu opened this issue Dec 17, 2023 · 0 comments
Assignees
@wallymathieu
Labels
F#+ v2.0

Comments

@wallymathieu
Copy link
Member

We currently have NET7_0 directives in the code base, these should be NET7 or greater rather than a specific version.

#if NET7_0

See preprocessor-directives

We have had trouble since NET?_OR_GREATER is not defined. Note the workaround in checking if not net45 et.c..

This is not a bug yet, since we have not yet released a version of F#+ compiled against a version greater than net6 (due to breaking changes in the F# compilation of assemblies).

See for instance:

#if !NET45 && !NETSTANDARD2_0 && !FABLE_COMPILER
@wallymathieu wallymathieu self-assigned this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wallymathieu wallymathieu

Labels
F#+ v2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wallymathieu