Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Validation type #499

Open
gusty opened this issue Sep 7, 2022 · 2 comments
Open

New Validation type #499

gusty opened this issue Sep 7, 2022 · 2 comments

Comments

@gusty
Copy link
Member

gusty commented Sep 7, 2022

I would like to swap the type parameters order, so instead of Validation<'TError, 'T> we define it like Validation<'T, 'TError>.

Also we could change the field names to Okay and Errors, the latter gives us a hint that it's about accumulative validation.

This is, of course for F#+ 2.0

@wallymathieu
Copy link
Member

Interesting suggestion. Could we do it in such a way that users of the lib doesn't get confused? I'm thinking about having it in a module that you would have to open, and putting a deprecation notice on the old one?

@gusty
Copy link
Member Author

gusty commented Sep 7, 2022

Yes, we have to think about it.
Anyways when the moment comes, I'm sure this won't be the sole type with such a breaking change.
We can then decide on which strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants