Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support DateOnly and TimeOnly types #1461

Open
nhirschey opened this issue Aug 17, 2022 · 2 comments
Open

Support DateOnly and TimeOnly types #1461

nhirschey opened this issue Aug 17, 2022 · 2 comments

Comments

@nhirschey
Copy link
Contributor

When this is moved to >= .NET6.0, it would be nice to add support for System.DateOnly and System.TimeOnly types. DateOnly in particular, because often a date is just a date.

Mentioning now b/c I see the repackaging major version bump, though maybe requiring net6.0 is not possible because type providers have to stay netstandard2.0.

I could contribute a PR for the functionality when it’s allowed.

@cartermp
Copy link
Collaborator

Yeah, if we broke compat with .NET Framework then we could do this I think. But that's a pretty big change to make, and although the majority of F# developers are not using .NET Framework, there are enough to make breaking that existing compat probably not worth it for a while. FWIW if there were no compat with .NET Framework to speak of today, I'd be completely in favor of this and not trying to find a way to add that compat.

@nhirschey
Copy link
Contributor Author

Makes sense. Backwards compatibility is a great F# feature, and DateOnly is still young.

thanks for considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants