Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illumos: track renames #630

Open
nshalman opened this issue May 1, 2024 · 1 comment
Open

illumos: track renames #630

nshalman opened this issue May 1, 2024 · 1 comment
Assignees
Labels

Comments

@nshalman
Copy link
Contributor

nshalman commented May 1, 2024

Follows from #628

Assigning to myself for now. If I don't make any progress on this in 2 weeks, we should attach the help wanted label and unassign it from me.

Breadcrumb for how to pick up on this :

I unexported RenamedFrom to renamedFrom for now, and the tests aren't run on platforms where this isn't supported yet (kq, fen). This way new features like this can be developed and merged in to main without holding up everything, and PRs can be a bit smaller in scope (I did some work on kqueue, which required rewriting significant bits of it).

To enable running the rename tests, add new platforms to supportsRename() in helpers_test.go over here: https://github.com/fsnotify/fsnotify/pull/628/files#diff-62f46d82044a129997b958c0f7eb6a95038395d337176418d3dffae98d9332d1R636

The goal would be to get the rename tests enabled on illumos and have them passing correctly. Additionally it would be nice, if possible, to remove any other illumos specific quirks in the test suite.

@nshalman nshalman self-assigned this May 1, 2024
@arp242
Copy link
Member

arp242 commented May 1, 2024

There's actually a few other illumos issues as well:

But really, there's no hurries with any of this, many of these have been feature requests that have been around for years, some over a decade. People have died of old age waiting for this – literally. It can wait a few months more.

I suspect one reason these features have never been done in spite of popular demand is that it required implementing at least 3 (now 4) different systems all at once; it's a lot to keep in your head, and a lot of work to squeeze in.

Just let me know when/if you look at any of this, to prevent double work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants