Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fsevents install a 'shim' when installed on non-OSX platforms #96

Closed
lxe opened this issue Oct 22, 2015 · 2 comments
Closed

Make fsevents install a 'shim' when installed on non-OSX platforms #96

lxe opened this issue Oct 22, 2015 · 2 comments

Comments

@lxe
Copy link

lxe commented Oct 22, 2015

This will allow for removing fsevents as optionalDependency and will fix shrink-wrapping of projects that target multiple platforms.

ref: paulmillr/chokidar#86
ref: madec-project/ezvis#85
ref: npm/npm#6801
ref: npm/npm#2679

@bnoordhuis
Copy link
Contributor

I don't think projects will be able to move away from having it as an optionalDependency.

npm will automatically try to run node-gyp (or node-pre-gyp) when it sees a binding.gyp in the top-level directory and that's going to fail when the user doesn't have a compiler installed (e.g. most Windows users.)

@es128
Copy link
Contributor

es128 commented Oct 22, 2015

I agree with @bnoordhuis. This would likely create a lot more pain than it would solve. Show us in a PR if you think we're wrong about that.

The issues with shrinkwrap and other various issues with the handling of optional and OS-specific deps are really npm's problem to solve.

Going to close the issue, but feel free to keep discussing.

@es128 es128 closed this as completed Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants