Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are BNDs filtered differently in primary and supplementary alignments? #426

Open
HillJamie opened this issue Sep 6, 2023 · 0 comments

Comments

@HillJamie
Copy link

When finding leads from split primary alignments, a mapq filter is applied (read_itersplits method)

if not config.dev_keep_lowqual_splits and min_mapq < config.mapq:

The same filter is commented out for supplementary alignments (see read_itersplits_bnd method).

#if not config.dev_keep_lowqual_splits and mapq < config.mapq:

Does this mean that reads will sometimes generate a BND for a supplementary alignment but not for the corresponding primary alignment? Then a BND might be called on the chromosome of the supplementary alignment, but without a corresponding BND on the chromosome of the primary alignment, even if all the reads have higher mapq for the primary alignment.

Perhaps the filter should only be used for non-BND types? If so, it could be moved to L470:

elif svtype!="NOSV" and not config.dev_keep_lowqual_splits and min_mapq < config.mapq:

Thank you for great software!
Jamie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant