Project Feedback!

[codepathreview]

👍 nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API.

• The model classes look good. I mentioned Mantle already for the Week 1 assignment as an example of another technique that some developers use for mapping JSON to models.
• NSDateFormatters are expensive to instantiate, so you can instantiate it once and use the same one, as long as you're using it from the same thread.
• In TweetListViewController.h, could you avoid exposing tweets and reloadData?
• In the addTweet function, why create another array? If you want to be able to insert an element into the array, why not make the original array of type NSMutableArray?
• Similarly, for other view controllers, do you need reloadData functions? If you create a custom setter for the model properties, you can call reloadData at the end of the custom setter.
• In TweetTableViewCell, do you need to expose retweetContainerHeightConstraint?
• In general, Auto Layout constraints look good. Generally, you shouldn't set a height constraint for labels, or it'll be too sensitive to the font. You can let the intrinsic content size drive the label height.
• Nice work handling the retweet label by dynamically modifying the constraint. Alternatively, you could have use a stack view to handle this case.

Overall, the other classes look good.