Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT Include GMX Spam Score #8

Open
RalfRoemling opened this issue Oct 28, 2020 · 11 comments
Open

FEAT Include GMX Spam Score #8

RalfRoemling opened this issue Oct 28, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@RalfRoemling
Copy link

Hi Overthere,
great plugin thanks alot :-)

One suggestion: Is it possible to implement other spamscores as well, e.g. the one from GMX?

X-GMX-Antispam: 6 (nemesis text pattern profiler); Detail=V3;
X-Spam-Flag: YES
@friedPotat0
Copy link
Owner

Thanks for opening this issue!

It seems that the scale is different for these headers. The values seem to consist only of positive values starting with 0 (no spam). Currently all mails with a score of 0 are marked yellow in the add-on. This would no longer apply to this scale.

First of all, the general score range customisability in the add-on options would have to be changed. I will keep it in mind for future versions, but I cannot promise that these headers will be supported very soon.

@friedPotat0 friedPotat0 added the enhancement New feature or request label Oct 30, 2020
@RalfRoemling
Copy link
Author

Yep, I know that the scales are different but because I changed my non-spam-rating to 0 to +2 I'm in the green :-)

But I understand what you're pointing at. Maybe one could modularize antispam-tools and their individual ranges? Eventually by the users themselves or as a plugin-architecture? I'm no programmer so I can't guess what kind of trouble this would be...

@friedPotat0
Copy link
Owner

As soon as I have a little more spare time, I will consider a general solution for additional spam headers. There are more and more requests for alternative headers.

One could certainly define the spam header score ranges as some kind of preset, so that a standard range is given based on the respective header, but it can be adjusted at any time.

@friedPotat0
Copy link
Owner

By looking at the search results when searching for "X-GMX-Antispam" it seems that GMX does not have a spam scale at all. The number written to the header is just the reason it is recognised as spam. Zero means "mail was not recognized as spam" and all other numbers refer to a specific spam reason.

image

All the add-on can do, is to display the red or green icon with a label "Spam" or "Ham". But no score can be displayed at all.

image

Let me know if this is what you were looking for. Otherwise, I would be very happy to discuss alternative solutions.

@RalfRoemling
Copy link
Author

yep, after some testing here seems you're right about not summing up.

What you think of adding the number of the reason in the column nonetheless? It would make identifiying patterns in the overview easier. (But in case it's to much hassle it's good as it is i quess :-)

@friedPotat0
Copy link
Owner

Actually, it's easier to show the reason number in the column instead of making a distinction between GMX and all other score patterns. But I thought it could be very confusing for people who have several mail accounts from different services forwarding to the same inbox.

Maybe something like "Spam (1)" would be more appropriate to make clear that even lower numbers mean that the mail is classified as spam.

@RalfRoemling
Copy link
Author

Hm, while rereading the thread I noticed that we missed sth.:
Your idea would work fine for GMX alone but if the intention was to implement support for multiple antispamtools and so to broaden the plugins usebase, this would lead to more trouble with other providers.

When thinking in this direction one would have to adapt the values in the column altogether, cause different tools would have different ranges for no-/spam indication.

Eventually one would add the technology used? e.g. sth like this:
GMX 2 (red)
SA -24 (green)
SA 1.5 (yellow)
SA 5 (red)
rspamd 5 (red)
EOP SCL 5 (yellow)
EOP SCL 0 (green)
EOP BCL 5 (yellow)
EOP BCL ... and so forth

Don't know wether this isn't a bit shootin' for the moon actually. It's your baby so it's your decision :-)

@friedPotat0
Copy link
Owner

Thanks for the feedback. I guess I won't implement GMX for the time being and instead work on a fine-tuned setting option in the add-on settings. I thought I could solve the GMX problem quickly, but there's actually more to it than I thought.

I'll get back as soon as I've managed to find a way of implementing it in a more general way.

@dlh2
Copy link
Contributor

dlh2 commented Oct 8, 2021

Hm, while rereading the thread I noticed that we missed sth.: Your idea would work fine for GMX alone but if the intention was to implement support for multiple antispamtools and so to broaden the plugins usebase, this would lead to more trouble with other providers.

When thinking in this direction one would have to adapt the values in the column altogether, cause different tools would have different ranges for no-/spam indication.

Eventually one would add the technology used? e.g. sth like this: GMX 2 (red) SA -24 (green) SA 1.5 (yellow) SA 5 (red) rspamd 5 (red) EOP SCL 5 (yellow) EOP SCL 0 (green) EOP BCL 5 (yellow) EOP BCL ... and so forth

Don't know wether this isn't a bit shootin' for the moon actually. It's your baby so it's your decision :-)

May I ask for multiple example mails so we can test them?

@RalfRoemling
Copy link
Author

What kind of mails do you need? Ham and Spam? I can provide some samples for gmx.de

How should I sent you these?

@dlh2
Copy link
Contributor

dlh2 commented Oct 11, 2021

Go to the emails you want to give as example and go inside them.

Then press Ctrl + U, it should give you the source code of the E-Mail

If you can separate the Header from the Content message that would be great.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants