Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a base pool class to consolidate the propose_power and related methods #922

Open
llucax opened this issue Apr 10, 2024 · 0 comments
Open
Labels
part:power-management Affects the management of battery power and distribution type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@llucax
Copy link
Contributor

llucax commented Apr 10, 2024

What's needed?

We have 3 different pools now, all using the same interface for managing power, but they don't share a common ancestor, so these methods could eventually inadvertently diverge, which is not what we want.

Proposed solution

Add an abstract base class to define the common interface of all pools so we can ensure they keep the same interface.

It should have at least the propose_power and power and power_status methods.

The name might be tricky, maybe PowerManagingComponentPool?

Additional context

Coming from:

@llucax llucax added type:enhancement New feature or enhancement visitble to users part:power-management Affects the management of battery power and distribution labels Apr 10, 2024
@llucax llucax added this to the v1.0.0-rc7 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:power-management Affects the management of battery power and distribution type:enhancement New feature or enhancement visitble to users
Projects
Status: To do
Development

No branches or pull requests

1 participant