Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ComponentGraph methods to work with abc.Set #917

Open
shsms opened this issue Apr 5, 2024 · 0 comments
Open

Update ComponentGraph methods to work with abc.Set #917

shsms opened this issue Apr 5, 2024 · 0 comments
Labels
type:enhancement New feature or enhancement visitble to users type:tech-debt Improves the project without visible changes for users
Milestone
v1.0.0-rc800

Comments

@shsms
Copy link
Contributor

shsms commented Apr 5, 2024

What's needed?

Most of the newer parts of the code base use abc.Set. But this isn't compatible with the methods of the component graph, because they still use set to type hint their parameters and return values. This leads to additional type conversions which can be avoided.

Proposed solution

Replace the uses of set with abc.Set in the component graph typehints.

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response
@shsms shsms added type:enhancement New feature or enhancement visitble to users type:tech-debt Improves the project without visible changes for users labels Apr 5, 2024
@llucax llucax added this to the v1.0.0-rc7 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement New feature or enhancement visitble to users type:tech-debt Improves the project without visible changes for users
Projects
Python SDK Roadmap
Status: To do
Milestone
v1.0.0-rc800
Development

No branches or pull requests
2 participants
@llucax @shsms