Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename xxx_pool() functions to new_xxx_pool() #915

Open
llucax opened this issue Apr 4, 2024 · 0 comments
Open

Rename xxx_pool() functions to new_xxx_pool() #915

llucax opened this issue Apr 4, 2024 · 0 comments
Labels
part:data-pipeline Affects the data pipeline part:microgrid Affects the interactions with the microgrid scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Milestone
v1.0.0-rc800

Comments

@llucax
Copy link
Contributor

llucax commented Apr 4, 2024

What's needed?

We need to make it more clear that functions like battery_pool() are not really used to get preexisting pools, but to create new ones.

Proposed solution

Rename xxx_pool() to new_xxx_pool() in frequenz.sdk.microgrid (and _DataPipeline).

Use cases

No response

Alternatives and workarounds

No response

Additional context
@llucax llucax added type:enhancement New feature or enhancement visitble to users part:data-pipeline Affects the data pipeline part:microgrid Affects the interactions with the microgrid scope:breaking-change Breaking change, users will need to update their code labels Apr 4, 2024
@llucax llucax modified the milestones: v1.0.0-rc6, v1.0.0-rc7 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:data-pipeline Affects the data pipeline part:microgrid Affects the interactions with the microgrid scope:breaking-change Breaking change, users will need to update their code type:enhancement New feature or enhancement visitble to users
Projects
Python SDK Roadmap
Status: To do
Milestone
v1.0.0-rc800
Development

No branches or pull requests
1 participant
@llucax