Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test cleanup in test_ev_charger_status.py #908

Open
shsms opened this issue Mar 28, 2024 · 0 comments
Open

Improve test cleanup in test_ev_charger_status.py #908

shsms opened this issue Mar 28, 2024 · 0 comments
Labels
part:tests Affects the unit, integration and performance (benchmarks) tests type:tech-debt Improves the project without visible changes for users
Milestone
v1.0.0-rc800

Comments

@shsms
Copy link
Contributor

shsms commented Mar 28, 2024

For proper cleanup, it might be a good idea to put this in a ExitStack, so it is cancelled and awaited even if the test exits due to an unhandled exception (like an assertion).

Originally posted by @llucax in #900 (comment)
@shsms shsms mentioned this issue Mar 28, 2024
Merged
@shsms shsms added part:tests Affects the unit, integration and performance (benchmarks) tests type:tech-debt Improves the project without visible changes for users labels Mar 28, 2024
@shsms shsms added this to the v1.0.0-rc7 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:tests Affects the unit, integration and performance (benchmarks) tests type:tech-debt Improves the project without visible changes for users
Projects
Python SDK Roadmap
Status: To do
Milestone
v1.0.0-rc800
Development

No branches or pull requests
1 participant
@shsms