Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace run_forever implementations with a generic one in _internal #906

Open
shsms opened this issue Mar 28, 2024 · 0 comments
Open

Replace run_forever implementations with a generic one in _internal #906

shsms opened this issue Mar 28, 2024 · 0 comments
Labels
part:data-pipeline Affects the data pipeline type:tech-debt Improves the project without visible changes for users
Milestone

Comments

@shsms
Copy link
Contributor

shsms commented Mar 28, 2024

This could be another reason to remove the auto-restart logic out of the actor, so we have a consistent policy for auto-restart. For example, the actor now has some sort of backoff to avoid a flood of restarts if it is "permanently" broken IIRC.

Since you are using this snippet in several places in this PR, maybe it is worth extracting the forever loop to a separate function in _internal and use it in the actor run and in the new places here? But it can be done in a separate PR too.

Originally posted by @llucax in #900 (comment)

Related issues

The solution to this issue needs to have in mind the following related issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:data-pipeline Affects the data pipeline type:tech-debt Improves the project without visible changes for users
Projects
Status: To do
Development

No branches or pull requests

1 participant