Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (re)active and apperent power to FormulaEngine #882

Open
matthias-wende-frequenz opened this issue Feb 22, 2024 · 4 comments
Open

Add (re)active and apperent power to FormulaEngine #882

matthias-wende-frequenz opened this issue Feb 22, 2024 · 4 comments
Labels
part:data-pipeline Affects the data pipeline part:microgrid Affects the interactions with the microgrid priority:low This should be addressed only if there is nothing else on the table type:enhancement New feature or enhancement visitble to users
Milestone

Comments

@matthias-wende-frequenz
Copy link
Contributor

What's needed?

At the moment when calling a high level power function we always return the active component of the power. We also want to be able to use the logical meter high level interface to read the other power components power.

Proposed solution

My suggested solution would be to add an optional parameter to the interface.

grid = microgrid.grid(power_component = ComponentMetricId.REACTIVE_POWER)

and add this as a parameter to the formula generator.

Use cases

No response

Alternatives and workarounds

No response

Additional context

No response

@matthias-wende-frequenz matthias-wende-frequenz added priority:high Address this as soon as possible type:enhancement New feature or enhancement visitble to users part:data-pipeline Affects the data pipeline part:microgrid Affects the interactions with the microgrid labels Feb 22, 2024
@matthias-wende-frequenz matthias-wende-frequenz added this to the v1.0.0-rc5 milestone Feb 22, 2024
@shsms
Copy link
Contributor

shsms commented Feb 22, 2024

Do we only need reactive power or do we need apparent power also? And do we need it just for the grid?

I think it has to be a separate function microgrid.grid().reactive_power, because that has a different unit(VAR) and needs a different Quantity type. Same for apparent_power, which is (VA).

@shsms
Copy link
Contributor

shsms commented Feb 22, 2024

Also does it have to be per-phase or single 3-phase values? did you have a usecase in mind for adding these, because that might tell us what the data should look like.

@llucax llucax modified the milestones: v1.0.0-rc5, v1.0.0-rc6 Feb 26, 2024
@matthias-wende-frequenz matthias-wende-frequenz removed the priority:high Address this as soon as possible label Mar 19, 2024
@merlin-esser-frequenz
Copy link

@shsms This ticket has been created based on a usecase which doesnt really need the SDK and can be solved using the Reporting API or the Microgrid API.
However, for the future it could be useful to also read out all the meter and inverter values via the FormulaEngine. But currently there is no priority for it.

@matthias-wende-frequenz
Copy link
Contributor Author

matthias-wende-frequenz commented Mar 26, 2024

@llucax llucax modified the milestones: v1.0.0-rc6, v1.0.0-rc7 Mar 26, 2024
@llucax llucax modified the milestones: v1.0.0-rc7, post-v1.0 Apr 9, 2024
@llucax llucax added the priority:low This should be addressed only if there is nothing else on the table label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:data-pipeline Affects the data pipeline part:microgrid Affects the interactions with the microgrid priority:low This should be addressed only if there is nothing else on the table type:enhancement New feature or enhancement visitble to users
Projects
Status: To do
Development

No branches or pull requests

4 participants