Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Decimal-backed Price Quantity-like class #850

Open
llucax opened this issue Jan 29, 2024 · 1 comment
Open

Add a Decimal-backed Price Quantity-like class #850

llucax opened this issue Jan 29, 2024 · 1 comment
Labels
part:core Affects the SDK core components (data structures, etc.) priority:low This should be addressed only if there is nothing else on the table type:enhancement New feature or enhancement visitble to users
Milestone
v1.0.0-rc800

Comments

@llucax
Copy link
Contributor

llucax commented Jan 29, 2024

What's needed?

The electricity trading API needs to deal with prices that are represented by a Decimal.

Proposed solution

Add a Price class to the quantities module, but Quantity is backed by a float.

Ideally we should have Price inherit from Quantity, and if that's not possible to at least have the same/similar interface.

Use cases

Electricity trading client

Alternatives and workarounds

Add this class to the electricity trading API client.

Additional context

No response
@llucax llucax added type:enhancement New feature or enhancement visitble to users part:core Affects the SDK core components (data structures, etc.) labels Jan 29, 2024
@llucax llucax added this to the v1.0.0-rc5 milestone Jan 29, 2024
@llucax
Copy link
Contributor Author

llucax commented Jan 29, 2024

@camille-bouvy-frequenz FYI

@llucax llucax modified the milestones: v1.0.0-rc5, v1.0.0-rc6 Feb 20, 2024
@llucax llucax modified the milestones: v1.0.0-rc6, v1.0.0-rc7 Mar 26, 2024
@llucax llucax added the priority:low This should be addressed only if there is nothing else on the table label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
part:core Affects the SDK core components (data structures, etc.) priority:low This should be addressed only if there is nothing else on the table type:enhancement New feature or enhancement visitble to users
Projects
Python SDK Roadmap
Status: To do
Milestone
v1.0.0-rc800
Development

No branches or pull requests
1 participant
@llucax