Replies: 1 comment
-
FYI @frequenz-floss/python-sdk-team |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Coming from #485.
I think there are a few different things at play here that are a bit mixed and made everything more confusing for me:
battery_pool
orlogical_meter
called to get these multiple/related metricsI think we should stick to the principle of keeping the data pipeline as simple as possible, so at the sample-level, I think we should only have single-valued samples (not sure how fundamentally needed the
Sample3Phase
is). So in this sense, no, I would rather not add more composedSample
classes.I also think the pipeline (including the
battery_pool
orlogical_meter
) shouldn't produce derived multi-metrics from one individual, like (lowest, highest, average), I think that should be done in a higher level, as it is also something that can be applied generically to any metric/sample, not just temperature. It is different if we need to derive a metric from some other because it is not provided directly, like we get voltage and current as metris and we need to get power, then I think thebattery_pool
should do that.I'm also not sure how this plays with pools, as for some metrics we want to be able to provide the individual values for each component in the pool, right?
So about 3, if we get 3 different metrics, apparent power, reactive power and active power, then from the API POV, for me the nicest would be to have:
Again, all I'm saying here is what I think is the best in abstract, maybe reality says something else.
Beta Was this translation helpful? Give feedback.
All reactions