Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default behavior to auto-publish #3

Open
DrewML opened this issue Jun 6, 2016 · 7 comments
Open

Switch default behavior to auto-publish #3

DrewML opened this issue Jun 6, 2016 · 7 comments

Comments

@DrewML
Copy link
Collaborator

DrewML commented Jun 6, 2016

TODO:

  • Remove --auto-publish flag
  • Change behavior of webstore (without sub-commands) to do an upload + publish
  • Make upload command include publishing by default
  • Add --no-publish flag to disable publishing when running upload command

refined-github/refined-github#235 (comment)

@sindresorhus
Copy link
Sponsor Contributor

sindresorhus commented Jun 6, 2016

Maybe it would be better if $ webstore (no sub-command) uploaded and published. If you want either independently, you can use the sub-commands. That way you don't need the flag and the most common use-case gets easier.

@DrewML
Copy link
Collaborator Author

DrewML commented Jun 6, 2016

👍 I like it. Less complexity, better DX.

@DrewML
Copy link
Collaborator Author

DrewML commented Jun 26, 2016

@sindresorhus Quick Q for you, since you have more experience writing CLIs than I do.

For the --help text, right now we have:

    Usage
      $ webstore <command>

    where <command> is one of
        upload, publish

What kind of verbiage would you expect to see here instead when those are optional, and the default is both?

@DrewML
Copy link
Collaborator Author

DrewML commented Jun 28, 2016

I've got a branch for this locally. Going to sit on it until #5 is ready so we only have to do a single major version bump.

@sindresorhus
Copy link
Sponsor Contributor

I dunno. Probably something like this:

Usage
  $ webstore [command]

Commands
  upload - Description
  publish - Description

When no command is specified it will both upload and publish

@sindresorhus
Copy link
Sponsor Contributor

Any movement on this?

@DrewML
Copy link
Collaborator Author

DrewML commented Sep 4, 2016

Sorry about that, will get to it soon. Have been putting it off in favor of some work on other projects, but definitely want to make it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants