Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetInput in has been renamed to SetInputData in vtkImageAlgorithm.h since VTK v.6.0.0 #1149

Open
aboualiaa opened this issue Dec 4, 2023 · 0 comments · May be fixed by #1150
Open

SetInput in has been renamed to SetInputData in vtkImageAlgorithm.h since VTK v.6.0.0 #1149

aboualiaa opened this issue Dec 4, 2023 · 0 comments · May be fixed by #1150

Comments

@aboualiaa
Copy link
Contributor

aboualiaa commented Dec 4, 2023 •
edited

SetInput is still used in this file, which causes a compilation error.

freesurfer/freeview/VolumeFilterThreshold.cpp

Line 42 in c385e43

filter->SetInput( m_volumeInput->GetImageData() );

here is the commit from vtk:
Kitware/VTK@4ea3677

the fix is a very simple rename, unless support for VTK v5 is necessary, but the packages which are officially distributed contain VTK v7, so I think it's safe to say that VTK v5 is not supported and should just be dropped from the code
@aboualiaa aboualiaa linked a pull request Dec 4, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update VolumeFilterThreshold.cpp aboualiaa/freesurfer
1 participant
@aboualiaa