Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse the order of parameters to type list ops #86

Open
andyscott opened this issue Nov 7, 2017 · 0 comments
Open

Reverse the order of parameters to type list ops #86

andyscott opened this issue Nov 7, 2017 · 0 comments
Milestone

Comments

@andyscott
Copy link
Member

The order of parameters to type list operations is counter intuitive and should be switched.

Consider

 def apply[L <: TList, LF <: TList](a: Cop[L])(fs: Prod[LF])(
      implicit ev: TList.Compute.Aux[Op.Map[? => B, L], LF]
    ): B =
      fs.values(a.index).asInstanceOf[Any => B].apply(a.value)

This would be more clearly expressed as

 def apply[L <: TList, LF <: TList](a: Cop[L])(fs: Prod[LF])(
      implicit ev: TList.Compute.Aux[Op.Map[LF, ? => B, L]]
    ): B =
      fs.values(a.index).asInstanceOf[Any => B].apply(a.value)
@andyscott andyscott added this to the Sprint 3 milestone Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant