Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the logging module to avoid transitive dependencies #513

Open
eperinan opened this issue Jan 17, 2018 · 0 comments
Open

Separate the logging module to avoid transitive dependencies #513

eperinan opened this issue Jan 17, 2018 · 0 comments

Comments

@eperinan
Copy link
Contributor

After the version 0.6.2, log4s was added as a wrapper for the logging module.

After this adding, we are importing transitively two dependencies, log4sand journal.

This would be inconvenient for someone who only wants to use log4s for example and doesn't want to have in the classpath the dependencies from journal.

For this reason, I propose to separate the logging module into three modules.

The first module with sloggingfor JS and the algebras.
The second module for journal whose depends on the first module
The third module for log4s whose depends on the first module as well

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant