Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing async module's codecov reports #306

Merged
merged 6 commits into from May 18, 2017
Merged

Conversation

dominv
Copy link
Contributor

@dominv dominv commented May 9, 2017

This issue resolves #307 and fixes the async module's codecov reports by renaming the async directory to freestyle-async

@raulraja, @juanpedromoreno could you please review?

Thanks!

@dominv dominv changed the title WIP Fixing async module's codecov reports May 9, 2017
@codecov-io
Copy link

codecov-io commented May 9, 2017

Codecov Report

Merging #306 into master will increase coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   83.25%   83.79%   +0.54%     
==========================================
  Files          24       25       +1     
  Lines         215      216       +1     
  Branches        2        2              
==========================================
+ Hits          179      181       +2     
+ Misses         36       35       -1

@dominv dominv requested review from juanpedromoreno and raulraja and removed request for juanpedromoreno May 9, 2017 21:59
@dominv dominv removed the request for review from juanpedromoreno May 9, 2017 22:05
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juanpedromoreno juanpedromoreno merged commit 48d5e3d into master May 18, 2017
@juanpedromoreno juanpedromoreno deleted the dv-280-fix-async-tests branch May 18, 2017 06:03
@anamariamv anamariamv added this to Done in freestyle Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Fix codecov reports for async module
4 participants