Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Customers" to "Name Reservations" in FireStore and code #3

Open
sanity opened this issue Sep 17, 2022 · 3 comments
Open

Rename "Customers" to "Name Reservations" in FireStore and code #3

sanity opened this issue Sep 17, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@sanity
Copy link
Contributor

sanity commented Sep 17, 2022

No description provided.

@sanity sanity added the enhancement New feature or request label Sep 17, 2022
@sanity
Copy link
Contributor Author

sanity commented Sep 17, 2022

Or delete "Customers" if it's no-longer relevant.

@Derek52
Copy link
Collaborator

Derek52 commented Sep 17, 2022

The plan was to have one table of reserved usernames, and then one table of email addresses that represent people. This is because an email address can have multiple reservations. "Name Reservations" sounds like it should be the name for the table of reserved usernames.

Technically, we don't need two tables, because everyone's email is stored with their reservation. But, having 2 tables makes it much easier to get a list of every email address, with no duplicates. We also log their email before they finish reserving their username. The second table lets us do that. "Customers" is the wrong name for that table now that I think about it. But, I don't think "Name reservations" is the right one either.

@sanity
Copy link
Contributor Author

sanity commented Sep 17, 2022

"names"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants