Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Babel from 2.5.1 to 2.9.1 #5968

Merged
merged 4 commits into from Jun 8, 2021
Merged

Update Babel from 2.5.1 to 2.9.1 #5968

merged 4 commits into from Jun 8, 2021

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review / Work in progress

Description of Changes

Fixes #5962

Updates Babel from 2.5.1 to 2.9.1

Testing

  • CI is passing
  • dependencies other than babel are unaffected.

Deployment

Deployed with securedrop-app-code install/update

Checklist

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

@zenmonkeykstop zenmonkeykstop requested a review from a team as a code owner June 2, 2021 19:46
@zenmonkeykstop zenmonkeykstop force-pushed the babel-2.9.1-bump branch 2 times, most recently from dd8ad68 to 6bf33a8 Compare June 2, 2021 23:47
@zenmonkeykstop zenmonkeykstop added this to Ready for Review in SecureDrop Team Board Jun 3, 2021
@zenmonkeykstop zenmonkeykstop added this to the 2.0.0 milestone Jun 3, 2021
Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Things still work, and the test changes here are necessary adjustments for new Babel behavior -- adding group separators, skipping empty messages when writing .mo files.

I tested the new fallback behavior when a message is simply missing from the .mo file, instead of being present with an empty message string, and nothing broke. You just get English, as expected.

@rmol rmol merged commit f318065 into develop Jun 8, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done Jun 8, 2021
@rmol rmol deleted the babel-2.9.1-bump branch June 8, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update Babel to >=2.9.1
3 participants