Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Application Server submissions checker runs 60 times a day #5927

Merged
merged 1 commit into from May 17, 2021

Conversation

prateekj117
Copy link
Contributor

@prateekj117 prateekj117 commented May 5, 2021

Status

Ready for review

Description of Changes

Application Server submissions checker runs 60 times a day because the crontab entry has * in minutes position. So the submission checker runs from 3, every minute till 4 which is daily_reboot_time.

Fixes #5847

Changes proposed in this pull request:
Add minutes value in crontab to be 0.

Testing

How should the reviewer test this PR?
Reference documentation is here.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to the system configuration:

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

@prateekj117 prateekj117 requested a review from a team as a code owner May 5, 2021 07:48
@eloquence eloquence added this to Ready for Review in SecureDrop Team Board May 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

Merging #5927 (b018a8f) into develop (98dbebc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5927   +/-   ##
========================================
  Coverage    85.37%   85.37%           
========================================
  Files           53       53           
  Lines         3876     3876           
  Branches       480      480           
========================================
  Hits          3309     3309           
  Misses         455      455           
  Partials       112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98dbebc...b018a8f. Read the comment docs.

Copy link
Contributor

@rmol rmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in a production setup and confirmed that this change corrects the crontab. Thanks @prateekj117.

@rmol rmol merged commit 04b2207 into freedomofpress:develop May 17, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

The Application Server submissions checker runs 60 times a day instead of once.
3 participants