Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated admin and development dependencies. #5925

Merged
merged 1 commit into from May 10, 2021
Merged

Conversation

zenmonkeykstop
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop commented May 4, 2021

Status

Ready for review.

Description of Changes

Updates admin and development dependencies based on dependabot reccos:

  • py 1.9.0 -> 1.10.0 (diff review complete)
  • ansible 2.9.7 -> 2.9.21 (diff review complete)

Testing

  • CI is passing
  • no new application dependencies introduced
  • diff review looks good

Deployment

  • admin dependencies updated with GUI or CLI update, dev dependencies must be applied manually (via pip -r)

Checklist

Choose one of the following:

  • I have opened a PR in the docs repo for these changes, or will do so later
  • I would appreciate help with the documentation
  • These changes do not require documentation

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

* py 1.9.0 -> 1.10.0
* ansible 2.9.7 -> 2.9.20
@codecov-commenter
Copy link

Codecov Report

Merging #5925 (31b9961) into develop (626e1dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5925   +/-   ##
========================================
  Coverage    85.37%   85.37%           
========================================
  Files           53       53           
  Lines         3876     3876           
  Branches       480      480           
========================================
  Hits          3309     3309           
  Misses         455      455           
  Partials       112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 626e1dd...31b9961. Read the comment docs.

@zenmonkeykstop zenmonkeykstop marked this pull request as ready for review May 5, 2021 21:25
@zenmonkeykstop zenmonkeykstop requested a review from a team as a code owner May 5, 2021 21:25
@zenmonkeykstop zenmonkeykstop added this to Ready for Review in SecureDrop Team Board May 5, 2021
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zenmonkeykstop

@emkll emkll moved this from Ready for Review to Under Review in SecureDrop Team Board May 10, 2021
@emkll emkll merged commit 2aec20b into develop May 10, 2021
SecureDrop Team Board automation moved this from Under Review to Done May 10, 2021
@emkll emkll deleted the deps-post-xenial branch May 10, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants