Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes virtualbox support in VM scenarios #5922

Merged
merged 1 commit into from May 19, 2021

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented May 4, 2021

Status

Ready for review.

Description of Changes

Towards #5904. In combination with freedomofpress/securedrop-docs#216, closes #5904.

Changes proposed in this pull request:

The team isn't using virtualbox actively, and for e.g. macos we have a
much more convenient docker dev env for making app code changes.
Let's remove virtualbox support entirely, until we have a pressing
reason for it.

Testing

These are mostly removals, building on changes in #5911. One important workflow to make sure we haven't broken is to provision prod VMs, and configure them via a virtualized Tails Admin Workstation. I've tested that myself, before opening this PR, and am satisfied with the behavior. Anyone else with a Debian Stable machine is welcome to try the same.

Deployment

Dev-only.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #5922 (aafbe73) into develop (4276758) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5922   +/-   ##
========================================
  Coverage    85.37%   85.37%           
========================================
  Files           53       53           
  Lines         3876     3876           
  Branches       480      480           
========================================
  Hits          3309     3309           
  Misses         455      455           
  Partials       112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4276758...aafbe73. Read the comment docs.

conorsch pushed a commit to freedomofpress/securedrop-docs that referenced this pull request May 4, 2021
Supplements freedomofpress/securedrop#5922.
Edits the dev docs to remove explicit mentions of Virtualbox, preferring
Libvirt (or Qubes) for any of the VM docs. Mostly this affects the macOS
docs. For macOS, we're now more clearly directing folks to use the
container dev env.
conorsch pushed a commit to freedomofpress/securedrop-docs that referenced this pull request May 4, 2021
Supplements freedomofpress/securedrop#5922.
Edits the dev docs to remove explicit mentions of Virtualbox, preferring
Libvirt (or Qubes) for any of the VM docs. Mostly this affects the macOS
docs. For macOS, we're now more clearly directing folks to use the
container dev env.
The team isn't using virtualbox actively, and for e.g. macos we have a
much more convenient docker dev env for making app code changes.
Let's remove virtualbox support entirely, until we have a pressing
reason for it.
@conorsch conorsch marked this pull request as ready for review May 5, 2021 00:45
@conorsch conorsch requested a review from a team as a code owner May 5, 2021 00:45
@conorsch
Copy link
Contributor Author

conorsch commented May 5, 2021

Marking as ready for review. Note that related docs changes are in freedomofpress/securedrop-docs#216, which is currently blocked by review on freedomofpress/securedrop-docs#214. Still, these changes can be reviewed on their own, so I'm not tagging this PR as blocked.

@conorsch conorsch moved this from In Development to Ready for Review in SecureDrop Team Board May 5, 2021
@garrettr
Copy link
Contributor

garrettr commented May 5, 2021

End of an era! Glad to see it go. Hopefully the newer infra is faster and more reliable!

conorsch pushed a commit to freedomofpress/securedrop-docs that referenced this pull request May 11, 2021
Supplements freedomofpress/securedrop#5922.
Edits the dev docs to remove explicit mentions of Virtualbox, preferring
Libvirt (or Qubes) for any of the VM docs. Mostly this affects the macOS
docs. For macOS, we're now more clearly directing folks to use the
container dev env.
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -31,6 +31,8 @@
tags:
- dns

# These services will be inside staging VMs via the Bento boxes,
# even if those boxes are running on libvirt.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈

# Default to VirtualBox, since it's the safest bet.
securedrop_vm_provider="virtualbox"
# We previously maintained Virtualbox support, but don't any longer. Should we?
echo "WARNING: Unsupported platform. Libvirt staging environment may not work properly."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good thanking

@sssoleileraaa sssoleileraaa merged commit eb6f4f8 into develop May 19, 2021
SecureDrop Team Board automation moved this from Ready for Review to Done May 19, 2021
@sssoleileraaa sssoleileraaa deleted the 5904-remove-virtualbox branch May 19, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Remove virtualbox support from VM scenarios
4 participants