Add cython < 3.0 constraint for dev requirements #7154
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make venv fails on Python 3.11 and greater due to incompatibility between our pinned PyYAML version and cython 3.0. For now, let's constrain the cython version to allow it to succeed. In future we should update development requirements.
The affected version is <2.14.14, making it dev-only. The admin tooling uses 2.15.9.
cfm
requested changes
May 2, 2024
There was a problem hiding this comment.
make venv passes for me on Python 3.9 (Debian 11) and Python 3.11 (Debian 12). It fails for me on Python 3.12 (macOS, from MacPorts) with:
_ruamel_yaml.c:28302:55: error: no member named 'ob_digit' in 'struct _longobject'
const digit* digits = ((PyLongObject*)x)->ob_digit;
~~~~~~~~~~~~~~~~~~ ^
_ruamel_yaml.c:28357:55: error: no member named 'ob_digit' in 'struct _longobject'
const digit* digits = ((PyLongObject*)x)->ob_digit;
~~~~~~~~~~~~~~~~~~ ^
_ruamel_yaml.c:28498:55: error: no member named 'ob_digit' in 'struct _longobject'
const digit* digits = ((PyLongObject*)x)->ob_digit;
~~~~~~~~~~~~~~~~~~ ^
_ruamel_yaml.c:28553:55: error: no member named 'ob_digit' in 'struct _longobject'
const digit* digits = ((PyLongObject*)x)->ob_digit;
~~~~~~~~~~~~~~~~~~ ^
_ruamel_yaml.c:28732:55: error: no member named 'ob_digit' in 'struct _longobject'
const digit* digits = ((PyLongObject*)x)->ob_digit;
~~~~~~~~~~~~~~~~~~ ^
_ruamel_yaml.c:28787:55: error: no member named 'ob_digit' in 'struct _longobject'
const digit* digits = ((PyLongObject*)x)->ob_digit;
~~~~~~~~~~~~~~~~~~ ^
_ruamel_yaml.c:29276:47: error: no member named 'ob_digit' in 'struct _longobject'
const digit* digits = ((PyLongObject*)b)->ob_digit;
~~~~~~~~~~~~~~~~~~ ^
133 warnings and 12 errors generated.
error: command '/usr/bin/clang' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for ruamel.yaml.clib
ERROR: Could not build wheels for ruamel.yaml.clib, which is required to install pyproject.toml-based projects
make: *** [venv] Error 1Let me know if you'd like me to take this over and investigate further, @zenmonkeykstop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review / Work in progress
Description of Changes
Fixes #7153
make venvfails on Python 3.11 and greater due to incompatibility between our pinned PyYAML version and cython 3.0. As a temporary measure, this PR (approach suggested by the original reporter on Gitter) constrains the cython version to allow it to succeed.(In future we should update PyYAML and development requirements in general.)
Testing
With Python 3.9 (eg debian 11):
make venvandmake devcomplete successfullyWith Python 3.11 (eg debian 12):
make venvandmake devcomplete successfullyWith Python 3.12, if available:
make venvandmake devcomplete successfullyCI passes
Visual review
Deployment
n/a, development only.