Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect service addresses in Source Interface metadata endpoint after data-only backup #5912

Closed
zenmonkeykstop opened this issue Apr 22, 2021 · 1 comment

Comments

@zenmonkeykstop
Copy link
Contributor

Description

After performing a data-only backup, the source interface /metadata endpoint will use the onion service address from the
backup instead of the instance's actual address. If the backup was v2-only or v2+v3, the v2 address will also be listed even if v2 services are disabled.

Steps to Reproduce

  • create a v3 instance
  • do a data-only restore from a backup with different service addresses.
  • observe the /metadata endpoint

Expected Behavior

Only the instance's actual SI interface(s) listed

Actual Behavior

Interface(s) from the backup listed.

Comments

Suggestions to fix, any other relevant information.

@eloquence
Copy link
Member

Closing per discussion at sprint planning today since v2_source_url was already removed from the metadata endpoint in #5926.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants