Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pbem as a standalone module #417

Open
fajfer opened this issue Aug 20, 2021 · 2 comments
Open

pbem as a standalone module #417

fajfer opened this issue Aug 20, 2021 · 2 comments

Comments

@fajfer
Copy link

fajfer commented Aug 20, 2021

Hello, this is more of an architecture thing but I don't understand why is pbem, which is written in different language than the rest of freeciv-web isn't a standalone module. It would make more sense as if you wouldn't want to use pbem you could just not build it and make the footprint of your server smaller. Instead, the entire freeciv-web is a monolithic docker image containing everything, forcing you to rebuild the entire monolith in case you want a tiny bit of it changed.

Is it a subject to change? Does it have to be like this? Thank you

@andreasrosdal
Copy link
Contributor

Python is an excellent programming language, and is used in other parts of Freeciv-web, such as freeciv-proxy, publite2 and in the scripts directory.
The current pbem module works. Still it could be improved and changed to have a different architecture.

@fajfer
Copy link
Author

fajfer commented Nov 14, 2021

Python is an excellent programming language, and is used in other parts of Freeciv-web, such as freeciv-proxy, publite2 and in the scripts directory. The current pbem module works. Still it could be improved and changed to have a different architecture.

Thank you for your answer Andreas. The point I'm trying to push here is that the entire freeciv is a monolith so you always build just one docker image instead of several for modules you would or would not want. This would allow easier development of the other modules and give the administrators the ability to not use certain modules they don't want to support on their servers. Would that be ok? I could prepare a change and, say, separate just pbem to see how that aligns with the freeciv-web devs and work on separating other modules if that's right or abandon the idea altogether. Would love to get your feedback as you probably have the most to say regarding the python modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants