Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publite2: civlauncher.py calls init-freeciv-web.sh #320

Open
andreasrosdal opened this issue Aug 31, 2020 · 0 comments
Open

Publite2: civlauncher.py calls init-freeciv-web.sh #320

andreasrosdal opened this issue Aug 31, 2020 · 0 comments

Comments

@andreasrosdal
Copy link
Contributor

andreasrosdal commented Aug 31, 2020

In Publite2, we need to change the way civlauncher.py calls init-freeciv-web.sh

https://github.com/freeciv/freeciv-web/blob/develop/publite2/civlauncher.py#L28

retcode = call(["/usr/bin/bash" , "../publite2/init-freeciv-web.sh" , self.savesdir , str(self.new_port) , str(1000 + self.new_port) , self.metahostpath , self.gametype , self.scripttype])

On Vagrant, this gave me a permission denied error, possibly because on Vagrant, Python doesn't have permission to execute ./publite2/init-freeciv-web.sh. The cause of the permission problems on Vagrant, is that VirtualBox doesn't support executable file permissions on mounted file systems like on native Linux.

So I added this workaround: 7adf93d

However, now the Travis CI build fails, because /usr/bin/bash is an invalid path there. So I had to revert the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant