Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

After deleting campaign, shouldn't the campaign subscriber be deleted too? #210

Open
shaikh-shahid opened this issue Sep 22, 2017 · 5 comments

Comments

@shaikh-shahid
Copy link

Trying it on local

Added around 1000 subs and created a campaign. After deleting the campaign, entries in compain subs tables persists, which I think should be deleted.

If there is any reason to keep them then let me know otherwise I will send a PR for a fix.

Thanks.

@karuppiah7890
Copy link
Contributor

@codeforgeek In Email marketing, people send multiple campaigns to the same list of subscribers. So, deleting a campaign shouldn't lead to deleting the subscribers

@shaikh-shahid
Copy link
Author

No you don't get it.

That part of subscribers is stored in list and list subscriber table. When we create compain and choose list, then that piece goes to compainsubscriber table. entries in that table should get deleted if we delete the compaign. Not from list or listsubscriber of course.

@karuppiah7890
Copy link
Contributor

Sorry, I thought you meant from a user's pov. You mean the database tables and entries; that's some technical stuff. I need to look into this.

@AndrewWalsh
Copy link
Member

@codeforgeek Agreed - this shouldn't happen. Will address this.

@shaikh-shahid
Copy link
Author

@AndrewGHC Let me help then! Will send PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants